Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplification in example of upload pub file #53

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Simplification in example of upload pub file #53

merged 1 commit into from
Oct 31, 2018

Conversation

gmembre-zenika
Copy link
Contributor

  • Change the type of ssh_public_key_names to be a list and remove split() calls
  • Remove file() call as the resources provides an source attribute to read local file

@gmembre-zenika
Simplification
e0a6419 
 * Change the type of `ssh_public_key_names` to be a list and remove `split()` calls
 * Remove `file()` call as the resources provides an `source` attribute to read local file
@gmembre-zenika gmembre-zenika changed the title Simplification Simplification in example of upload pub file Oct 30, 2018
@charlyx
Copy link
Contributor

charlyx commented Oct 30, 2018

Much better! 😎

@antonbabenko antonbabenko merged commit 8252af4 into terraform-community-modules:master Oct 31, 2018
@antonbabenko
Copy link
Member

Thanks, @gmembre-zenika and all reviewers. More eyes are better :)

v1.9.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmembre-zenika @charlyx @antonbabenko